Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HealthInsights] Publish Private branch prajwalkumar/healthinsights #24079

Merged
merged 2 commits into from
May 26, 2023
Merged

[HealthInsights] Publish Private branch prajwalkumar/healthinsights #24079

merged 2 commits into from
May 26, 2023

Conversation

prajwalkumar-msft
Copy link
Contributor

Data Plane API - Pull Request

Updating examples for the REST api calls to HealthInsights.OncoPhenotype. Examples were slightly outdated and api no longer requires patient info metadata to run request.

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

No changes to api or scope, just documentation

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

@openapi-workflow-bot
Copy link

Hi, @prajwalkumar-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @ghost ghost added the Cognitive Services label May 19, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 19, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⌛CredScan pending [Detail]
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand] 
    Validation passes for ServiceAPIReadinessTest.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️⌛PoliCheck pending [Detail]
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand] 
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 19, 2023 •
    edited
    Loading

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

    @prajwalkumar-msft prajwalkumar-msft changed the title [HealthInsights] Update OncoPhenotype examples [HealthInsights] Publish Private branch prajwalkumar/healthinsights May 19, 2023
    @prajwalkumar-msft
    Copy link
    Contributor Author

    The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR https://github.com/Azure/azure-rest-api-specs-pr/pull/12643

    @JackTn
    Copy link
    Member

    JackTn commented May 22, 2023

    approved

    @JackTn JackTn added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 22, 2023
    @JackTn
    Copy link
    Member

    JackTn commented May 22, 2023

    @msyyc help to take a look on this pr and merge it, Thanks

    @msyyc msyyc merged commit 6cb5f52 into main May 26, 2023
    @msyyc msyyc deleted the published/prajwalkumar-msft/azure-rest-api-specs-pr/prajwalkumar/healthinsights branch May 26, 2023 01:50
    @mikeharder mikeharder mentioned this pull request May 26, 2023
    Closed
    mikeharder added a commit to mikeharder/azure-rest-api-specs that referenced this pull request May 26, 2023
    @mikeharder
    Revert "[HealthInsights] Publish Private branch prajwalkumar/healthin…
    377dfec 
    …sights (Azure#24079)"

This reverts commit 6cb5f52.
    mikeharder added a commit that referenced this pull request May 26, 2023
    @mikeharder
    Revert "[HealthInsights] Publish Private branch prajwalkumar/healthin…
    dc92283 
    …sights (#24079)" (#24179)

- This reverts commit 6cb5f52.
- Required to unblock CI pipeline, since original PR did not copy examples to output dir
- Copied changes to PR #24177, but this PR is failing "Swagger ModelValidation"
    mikeharder added a commit to mikeharder/azure-rest-api-specs that referenced this pull request May 26, 2023
    @mikeharder
    Add examples from PR Azure#24079
    e5cc3d3
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @msyyc msyyc msyyc approved these changes

    @yangyuan yangyuan Awaiting requested review from yangyuan yangyuan is a code owner

    Assignees

    @JackTn JackTn

    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates Cognitive Services
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @prajwalkumar-msft @JackTn @msyyc